Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-3201 - Allow Staff to use date picker to select start date in past #1711

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Dec 11, 2024

Description

Allow staff users to select a past date in CustomDatePicker, display warning message when doing so.
Please see onRouteBCSpecification for details

Fixes #ORV2-3201

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

Copy link

Copy link

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
42.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@glen-aot glen-aot merged commit 51727fa into main Dec 16, 2024
23 of 24 checks passed
@glen-aot glen-aot deleted the ORV2-3201 branch December 16, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants